Turning off the bot only stops the Gameloop.Update handler in ffxiv_task_lua. There's absolutely no requirement that all lua code uses the same update handler function therefore by only stopping one of them you open up the possibility of having severe sync issues and possibly even crashes if one module expects certain data to be available/updated that is no longer valid due to having stopped the update handler that maintains that data.
We're not dummies, we know how this stuff works. If we say something is tricky its because we've considered it long ago and haven't decided on a good, safe implementation of it yet. An easy three minute hack is not the kind of code that we put into the main bot lua without considering all the implications (or at least that should be the ideal we strive for, if sometimes unfortunately fall short of). The reason I suggested the possibility of a solution from the C++ side is that we can simply stop the update loop pulse from being passed to the lua modules completely, which removes the possibility of one module getting updated while another does not. That's the only safe solution that won't lead to addon errors and maintainability problems down the road.
Edit: If that wasn't enough reason not to use this solution, the bot also resets all its data when its toggled on and off. Therefore you're not actually "pausing" it, you're "resetting" it, and there's a good possibility that the bot will not continue the action you were in the middle of when you start again.
Edit Again: Also, you can already do this. It's called "Ctrl-S" and works by default.
We're not dummies, we know how this stuff works. If we say something is tricky its because we've considered it long ago and haven't decided on a good, safe implementation of it yet. An easy three minute hack is not the kind of code that we put into the main bot lua without considering all the implications (or at least that should be the ideal we strive for, if sometimes unfortunately fall short of). The reason I suggested the possibility of a solution from the C++ side is that we can simply stop the update loop pulse from being passed to the lua modules completely, which removes the possibility of one module getting updated while another does not. That's the only safe solution that won't lead to addon errors and maintainability problems down the road.
Edit: If that wasn't enough reason not to use this solution, the bot also resets all its data when its toggled on and off. Therefore you're not actually "pausing" it, you're "resetting" it, and there's a good possibility that the bot will not continue the action you were in the middle of when you start again.
Edit Again: Also, you can already do this. It's called "Ctrl-S" and works by default.